MySmartHome/MySensors
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cppcheck issues (#1036)

Browse Source 
Fixes the following cppcheck issues:
examples/SecretKnockSensor/SecretKnockSensor.ino
305	variableScope	398	style
The scope of the variable 'timeDiff' can be reduced.

examples/SensebenderGatewaySerial/SensebenderGatewaySerial.ino
127	variableScope	398	style
The scope of the variable 'led_state' can be reduced.
This commit is contained in:
Mikael Falkvidd
2018-01-28 09:31:19 +01:00
committed by tekka
parent 52ac498eda
commit 06269dd949
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/SecretKnockSensor/SecretKnockSensor.ino
+1 -2
View File
@@ -302,8 +302,7 @@ bool validateKnock()
less of a pain to use if you're tempo is a little slow or fast. less of a pain to use if you're tempo is a little slow or fast.
*/ */
int totaltimeDifferences = 0; int totaltimeDifferences = 0;
int timeDiff = 0; for (int timeDiff = 0, i=0; i < maximumKnocks; i++) { // Normalize the times
for (i=0; i < maximumKnocks; i++) { // Normalize the times
knockReadings[i]= map(knockReadings[i], 0, maxKnockInterval, 0, 100); knockReadings[i]= map(knockReadings[i], 0, maxKnockInterval, 0, 100);
timeDiff = abs(knockReadings[i] - secretCode[i]); timeDiff = abs(knockReadings[i] - secretCode[i]);
if (timeDiff > if (timeDiff >
examples/SensebenderGatewaySerial/SensebenderGatewaySerial.ino
+1 -1
View File
@@ -124,8 +124,8 @@ void preHwInit()
for (int i=0; i< num_of_leds; i++) { for (int i=0; i< num_of_leds; i++) {
pinMode(leds[i], OUTPUT); pinMode(leds[i], OUTPUT);
} }
uint8_t led_state = 0;
if (digitalRead(MY_SWC1)) { if (digitalRead(MY_SWC1)) {
uint8_t led_state = 0;
while (!Serial) { while (!Serial) {
digitalWrite(LED_BLUE, led_state); digitalWrite(LED_BLUE, led_state);
led_state ^= 0x01; led_state ^= 0x01;