Merge pull request #80 from mapnull/hotfix-mqtt-read_mqtt_packets

MQTTGateway: fix garbage in MQTT payload
This commit is contained in:
Henrik Ekblad
2015-02-27 00:22:25 +01:00
@@ -61,14 +61,14 @@ http://forum.mysensors.org/topic/303/mqtt-broker-gateway
#include <MyMQTT.h> #include <MyMQTT.h>
#include <Ethernet.h> #include <Ethernet.h>
// * Use this for IBOARD modded to use standard MISO/MOSI/SCK, see note *1 above! // * Use this for IBOARD modded to use standard MISO/MOSI/SCK, see note *1 above!
/* /*
#define RADIO_CE_PIN 3 // radio chip enable #define RADIO_CE_PIN 3 // radio chip enable
#define RADIO_SPI_SS_PIN 8 // radio SPI serial select #define RADIO_SPI_SS_PIN 8 // radio SPI serial select
#define RADIO_ERROR_LED_PIN A2 // Error led pin #define RADIO_ERROR_LED_PIN A2 // Error led pin
#define RADIO_RX_LED_PIN A1 // Receive led pin #define RADIO_RX_LED_PIN A1 // Receive led pin
#define RADIO_TX_LED_PIN A0 // the PCB, on board LED*/ #define RADIO_TX_LED_PIN A0 // the PCB, on board LED
*/
// * Use this for default configured pro mini / nano etc : // * Use this for default configured pro mini / nano etc :
///* ///*
@@ -90,17 +90,32 @@ MyMQTT gw(RADIO_CE_PIN, RADIO_SPI_SS_PIN);
void processEthernetMessages() { void processEthernetMessages() {
char inputString[MQTT_MAX_PACKET_SIZE] = ""; char inputString[MQTT_MAX_PACKET_SIZE] = "";
uint8_t inputSize = 0; uint8_t inputSize = 0;
uint8_t readCnt = 0;
uint8_t length = 0;
EthernetClient client = server.available(); EthernetClient client = server.available();
if (client) { if (client) {
while (client.available()) { while (client.available()) {
char inChar = client.read(); uint8_t inChar = client.read();
inputString[inputSize] = inChar; readCnt++;
if (inputSize < MQTT_MAX_PACKET_SIZE-1) {
inputString[inputSize] = (char)inChar;
inputSize++; inputSize++;
} }
if (readCnt == 2) {
length = (inChar & 127) * 1;
}
if (readCnt == (length+2)) {
break;
}
}
inputString[inputSize] = 0;
#ifdef TCPDUMP #ifdef TCPDUMP
Serial.print("<<"); Serial.print("<<");
char buf[4]; char buf[4];
for (uint8_t a=0; a<inputSize; a++) { sprintf(buf,"%02X ", (uint8_t)inputString[a]); Serial.print(buf); } Serial.println(""); for (uint8_t a=0; a<inputSize; a++) { sprintf(buf, "%02X ", (uint8_t)inputString[a]); Serial.print(buf); } Serial.println();
#endif #endif
gw.processMQTTMessage(inputString, inputSize); gw.processMQTTMessage(inputString, inputSize);
} }
@@ -110,7 +125,7 @@ void writeEthernet(const char *writeBuffer, uint8_t *writeSize) {
#ifdef TCPDUMP #ifdef TCPDUMP
Serial.print(">>"); Serial.print(">>");
char buf[4]; char buf[4];
for (uint8_t a=0; a<*writeSize; a++) { sprintf(buf,"%02X ",(uint8_t)writeBuffer[a]); Serial.print(buf); } Serial.println(""); for (uint8_t a=0; a<*writeSize; a++) { sprintf(buf,"%02X ",(uint8_t)writeBuffer[a]); Serial.print(buf); } Serial.println();
#endif #endif
server.write((const uint8_t *)writeBuffer, *writeSize); server.write((const uint8_t *)writeBuffer, *writeSize);
} }