From 0252aac8ae3b29d1402080d3e59330d56da9cfe6 Mon Sep 17 00:00:00 2001
From: Dennis Keitzel <github@pinshot.net>
Date: Wed, 19 Dec 2018 10:36:02 +0100
Subject: [PATCH] Use a single mqtt connection for publish and subscribe
 operations instead of separate one-shot connections for each update (#35)

---
 mqtt.py | 37 +++++++++++++------------------------
 1 file changed, 13 insertions(+), 24 deletions(-)

diff --git a/mqtt.py b/mqtt.py
index 24f7f35..0ff9c13 100644
--- a/mqtt.py
+++ b/mqtt.py
@@ -1,29 +1,25 @@
-import paho.mqtt.publish as publish
 import paho.mqtt.client as mqtt
 
+
 class MqttClient:
 
   def __init__(self, config):
     self._config = config
     self._mqttc = mqtt.Client(client_id=self.client_id, clean_session=False)
-    
-    if self.username is not None and self.password is not None:
-      self._auth = {'username': self.username, 'password': self.password}
-    else:
-      self._auth = None
+
+    if self.username and self.password:
+      self.mqttc.username_pw_set(self.username, self.password)
+
+    self.mqttc.connect(self.hostname, port=self.port)
+    self.mqttc.loop_start()
 
   def publish(self, messages):
-    if messages is None or len(messages) == 0:
+    if not messages:
       return
-    
-    if self.topic_prefix is not None:
-      for m in messages:
-        m.topic = "{}/{}".format(self.topic_prefix, m.topic)
-    
-    publish.multiple(list(map(lambda m: m.as_dict, messages)),
-                     hostname=self.hostname,
-                     port=self.port,
-                     auth=self._auth)
+
+    for m in messages:
+      topic = "{}/{}".format(self.topic_prefix, m.topic) if self.topic_prefix else m.topic
+      self.mqttc.publish(topic, m.payload)
 
   @property
   def client_id(self):
@@ -54,18 +50,11 @@ class MqttClient:
     return self._mqttc
 
   def callbacks_subscription(self, callbacks):
-    if self.username is not None and self.password is not None:
-      self.mqttc.username_pw_set(self.username, self.password)
-    self.mqttc.connect(self.hostname, port=self.port)
-
     for topic, callback in callbacks:
-      if self.topic_prefix:
-        topic = "{}/{}".format(self.topic_prefix, topic)
+      topic = "{}/{}".format(self.topic_prefix, topic) if self.topic_prefix else topic
       self.mqttc.message_callback_add(topic, callback)
       self.mqttc.subscribe(topic)
 
-    self.mqttc.loop_start()
-
 
 class MqttMessage:
   def __init__(self, topic=None, payload=None):