From 29d41b4ed0ab2f9a7699ac5f0cc35146ff6642d5 Mon Sep 17 00:00:00 2001 From: Vasily Date: Tue, 19 Feb 2019 18:29:22 +0100 Subject: [PATCH] Add -Wconversion to GCC and Clang clang-msvc spams warnings from the moc .cpp files that include Qt headers. --- build_scripts/qt/compilers/clang-msvc.pri | 4 ++-- build_scripts/qt/compilers/clang.pri | 2 +- build_scripts/qt/compilers/gcc.pri | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build_scripts/qt/compilers/clang-msvc.pri b/build_scripts/qt/compilers/clang-msvc.pri index a554020..d80d1c5 100644 --- a/build_scripts/qt/compilers/clang-msvc.pri +++ b/build_scripts/qt/compilers/clang-msvc.pri @@ -14,5 +14,5 @@ QMAKE_CXXFLAGS += -Wmost QMAKE_CXXFLAGS += -Weffc++ -#QMAKE_CXXFLAGS += -Wconversion -QMAKE_CXXFLAGS += -Wsign-conversion +#clang-msvc spams warnings on -Wconversion and -Wsign-conversion +# from the moc .cpp files including Qt stuff. diff --git a/build_scripts/qt/compilers/clang.pri b/build_scripts/qt/compilers/clang.pri index 39ebd07..0c16ae1 100644 --- a/build_scripts/qt/compilers/clang.pri +++ b/build_scripts/qt/compilers/clang.pri @@ -8,4 +8,4 @@ QMAKE_CXXFLAGS += -Werror #All includes from the third-party directory will not warn. QMAKE_CXXFLAGS += --system-header-prefix=third-party -QMAKE_CXXFLAGS += -Weffc++ +QMAKE_CXXFLAGS += -Weffc++ -Wconversion diff --git a/build_scripts/qt/compilers/gcc.pri b/build_scripts/qt/compilers/gcc.pri index df05be5..984ccdf 100644 --- a/build_scripts/qt/compilers/gcc.pri +++ b/build_scripts/qt/compilers/gcc.pri @@ -9,3 +9,5 @@ QMAKE_CXXFLAGS += -Werror # GCC only switches QMAKE_CXXFLAGS += -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wrestrict -Wnull-dereference + +QMAKE_CXXFLAGS += -Wconversion