From 3f8f757ead21715b3941110b5aa47a75645ac297 Mon Sep 17 00:00:00 2001 From: Vasily Date: Sat, 25 May 2019 12:21:29 +0200 Subject: [PATCH] Add error logging for keyboard input --- src/keyboard_input/input_parser.cpp | 5 ++--- src/keyboard_input/input_parser.h | 1 + src/keyboard_input/input_sender_X11.cpp | 1 - src/keyboard_input/input_sender_win.cpp | 1 - 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/keyboard_input/input_parser.cpp b/src/keyboard_input/input_parser.cpp index 7f5eff8..28ca18b 100644 --- a/src/keyboard_input/input_parser.cpp +++ b/src/keyboard_input/input_parser.cpp @@ -50,7 +50,7 @@ std::optional getFunctionNumber( const char& character ) noexcept return Token::KEY_F9; default: - // LOG incorrect character + LOG( INFO ) << "Unknown function key number: " << character; return std::nullopt; } } @@ -147,7 +147,6 @@ std::optional checkIfLegalCapitalLiteral( std::string input ) noexcept return Token::KEY_ENTER; } - // LOG incorrect character return std::nullopt; } @@ -176,7 +175,7 @@ std::vector if ( !isupper( *ch ) || isspace( *ch ) ) { - // LOG incorrect character + LOG( INFO ) << "Unknown character found in sequence: " << ch; continue; } // Everything below is upper case diff --git a/src/keyboard_input/input_parser.h b/src/keyboard_input/input_parser.h index 037a3bb..9ad8329 100644 --- a/src/keyboard_input/input_parser.h +++ b/src/keyboard_input/input_parser.h @@ -3,6 +3,7 @@ #include #include #include +#include enum class Token { diff --git a/src/keyboard_input/input_sender_X11.cpp b/src/keyboard_input/input_sender_X11.cpp index a05eb01..d89fc2e 100644 --- a/src/keyboard_input/input_sender_X11.cpp +++ b/src/keyboard_input/input_sender_X11.cpp @@ -86,7 +86,6 @@ unsigned int tokenToKeyCode( const Token token, Display* const display ) return XK_Super_L; default: - // LOG incorrect symbol return 0; } } diff --git a/src/keyboard_input/input_sender_win.cpp b/src/keyboard_input/input_sender_win.cpp index 5a57faf..f409a99 100644 --- a/src/keyboard_input/input_sender_win.cpp +++ b/src/keyboard_input/input_sender_win.cpp @@ -86,7 +86,6 @@ WORD convertToVirtualKeycode( const Token token ) return VK_LWIN; default: - // LOG incorrect symbol return 0; } }