Remove widget pointer from SteamVRTabController
The pointer is not needed and is an anti pattern.
This commit is contained in:
@@ -484,7 +484,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
|
|||||||
|
|
||||||
m_pPumpEventsTimer->start();
|
m_pPumpEventsTimer->start();
|
||||||
|
|
||||||
m_steamVRTabController.initStage2( this, m_pWindow.get() );
|
m_steamVRTabController.initStage2( this );
|
||||||
m_chaperoneTabController.initStage2( this, m_pWindow.get() );
|
m_chaperoneTabController.initStage2( this, m_pWindow.get() );
|
||||||
m_fixFloorTabController.initStage2( this, m_pWindow.get() );
|
m_fixFloorTabController.initStage2( this, m_pWindow.get() );
|
||||||
m_audioTabController.initStage2( this, m_pWindow.get() );
|
m_audioTabController.initStage2( this, m_pWindow.get() );
|
||||||
|
|||||||
@@ -13,11 +13,9 @@ void SteamVRTabController::initStage1()
|
|||||||
reloadSteamVRProfiles();
|
reloadSteamVRProfiles();
|
||||||
}
|
}
|
||||||
|
|
||||||
void SteamVRTabController::initStage2( OverlayController* var_parent,
|
void SteamVRTabController::initStage2( OverlayController* var_parent )
|
||||||
QQuickWindow* var_widget )
|
|
||||||
{
|
{
|
||||||
this->parent = var_parent;
|
this->parent = var_parent;
|
||||||
this->widget = var_widget;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void SteamVRTabController::eventLoopTick()
|
void SteamVRTabController::eventLoopTick()
|
||||||
|
|||||||
@@ -44,7 +44,6 @@ class SteamVRTabController : public QObject
|
|||||||
|
|
||||||
private:
|
private:
|
||||||
OverlayController* parent;
|
OverlayController* parent;
|
||||||
QQuickWindow* widget;
|
|
||||||
|
|
||||||
float m_superSampling = 1.0;
|
float m_superSampling = 1.0;
|
||||||
bool m_motionSmoothing = true;
|
bool m_motionSmoothing = true;
|
||||||
@@ -61,7 +60,7 @@ private:
|
|||||||
|
|
||||||
public:
|
public:
|
||||||
void initStage1();
|
void initStage1();
|
||||||
void initStage2( OverlayController* parent, QQuickWindow* widget );
|
void initStage2( OverlayController* parent );
|
||||||
|
|
||||||
void eventLoopTick();
|
void eventLoopTick();
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user