From 81ae0efd1c94ea9268f033b9140a34a8565ba78c Mon Sep 17 00:00:00 2001
From: Vasily <vautkin@teknik.io>
Date: Tue, 19 Feb 2019 20:55:01 +0100
Subject: [PATCH] Add -Wmissing-variable-declarations to all clang/gcc
 compilers

---
 .../compilers/clang-gcc-common-switches.pri   |  2 +-
 src/tabcontrollers/ReviveTabController.cpp    | 38 +++++++++----------
 src/tabcontrollers/UtilitiesTabController.cpp |  2 +-
 3 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/build_scripts/qt/compilers/clang-gcc-common-switches.pri b/build_scripts/qt/compilers/clang-gcc-common-switches.pri
index fca9988..9436a7c 100644
--- a/build_scripts/qt/compilers/clang-gcc-common-switches.pri
+++ b/build_scripts/qt/compilers/clang-gcc-common-switches.pri
@@ -8,4 +8,4 @@ QMAKE_CXXFLAGS += -Wnon-virtual-dtor
 
 QMAKE_CXXFLAGS += -Wcast-align -Wunused -Woverloaded-virtual -Wformat=2
 
-QMAKE_CXXFLAGS += -Wdouble-promotion
+QMAKE_CXXFLAGS += -Wdouble-promotion -Wmissing-variable-declarations
diff --git a/src/tabcontrollers/ReviveTabController.cpp b/src/tabcontrollers/ReviveTabController.cpp
index 50a6f81..8c8e5ae 100644
--- a/src/tabcontrollers/ReviveTabController.cpp
+++ b/src/tabcontrollers/ReviveTabController.cpp
@@ -5,25 +5,25 @@
 // application namespace
 namespace advsettings
 {
-const char* appkey_overlay = "revive.dashboard.overlay";
-const char* section_revive = "revive";
-const char* key_pixelsPerDisplayPixel = "pixelsPerDisplayPixel";
-const char* key_toggleGrip = "ToggleGrip";
-const char* key_triggerAsGrip = "TriggerAsGrip";
-const char* key_toggleDelay = "ToggleDelay";
-const char* key_thumbDeadzone = "ThumbDeadzone";
-const char* key_thumbSensitivity = "ThumbSensitivity";
-const char* key_touchPitch = "TouchPitch";
-const char* key_touchYaw = "TouchYaw";
-const char* key_touchRoll = "TouchRoll";
-const char* key_touchX = "TouchX";
-const char* key_touchY = "TouchY";
-const char* key_touchZ = "TouchZ";
-const char* key_playerHeight = "PlayerHeight";
-const char* key_eyeHeight = "EyeHeight";
-const char* key_piUser = "User";
-const char* key_piName = "Name";
-const char* key_piGender = "Gender";
+constexpr auto appkey_overlay = "revive.dashboard.overlay";
+constexpr auto section_revive = "revive";
+constexpr auto key_pixelsPerDisplayPixel = "pixelsPerDisplayPixel";
+constexpr auto key_toggleGrip = "ToggleGrip";
+constexpr auto key_triggerAsGrip = "TriggerAsGrip";
+constexpr auto key_toggleDelay = "ToggleDelay";
+constexpr auto key_thumbDeadzone = "ThumbDeadzone";
+constexpr auto key_thumbSensitivity = "ThumbSensitivity";
+constexpr auto key_touchPitch = "TouchPitch";
+constexpr auto key_touchYaw = "TouchYaw";
+constexpr auto key_touchRoll = "TouchRoll";
+constexpr auto key_touchX = "TouchX";
+constexpr auto key_touchY = "TouchY";
+constexpr auto key_touchZ = "TouchZ";
+constexpr auto key_playerHeight = "PlayerHeight";
+constexpr auto key_eyeHeight = "EyeHeight";
+constexpr auto key_piUser = "User";
+constexpr auto key_piName = "Name";
+constexpr auto key_piGender = "Gender";
 
 void ReviveTabController::initStage1( bool forceRevivePage )
 {
diff --git a/src/tabcontrollers/UtilitiesTabController.cpp b/src/tabcontrollers/UtilitiesTabController.cpp
index b525541..9d9b305 100644
--- a/src/tabcontrollers/UtilitiesTabController.cpp
+++ b/src/tabcontrollers/UtilitiesTabController.cpp
@@ -12,7 +12,7 @@
 // application namespace
 namespace advsettings
 {
-const char* steamDesktopOverlaykey = "valve.steam.desktop";
+constexpr auto steamDesktopOverlaykey = "valve.steam.desktop";
 
 void UtilitiesTabController::initStage1()
 {