diff --git a/build_scripts/qt/compilers/clang.pri b/build_scripts/qt/compilers/clang.pri index 228ca95..f897c2c 100644 --- a/build_scripts/qt/compilers/clang.pri +++ b/build_scripts/qt/compilers/clang.pri @@ -10,3 +10,5 @@ QMAKE_CXXFLAGS += --system-header-prefix=third-party # Sign conversion warns on auto generated Qt MOC files. QMAKE_CXXFLAGS += -Weffc++ -Wconversion -Wno-sign-conversion + +QMAKE_CXXFLAGS += -Wextra-semi diff --git a/build_scripts/qt/compilers/gcc.pri b/build_scripts/qt/compilers/gcc.pri index 0da6167..593351a 100644 --- a/build_scripts/qt/compilers/gcc.pri +++ b/build_scripts/qt/compilers/gcc.pri @@ -12,3 +12,5 @@ QMAKE_CXXFLAGS += -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wrestric # Sign conversion warns on auto generated Qt MOC files. QMAKE_CXXFLAGS += -Wconversion -Wno-sign-conversion + +QMAKE_CXXFLAGS += -Wextra-semi diff --git a/src/overlaycontroller.h b/src/overlaycontroller.h index 252f258..2a9f94f 100644 --- a/src/overlaycontroller.h +++ b/src/overlaycontroller.h @@ -165,7 +165,7 @@ public: bool isDesktopMode() { return m_desktopMode; - }; + } utils::ChaperoneUtils& chaperoneUtils() noexcept { diff --git a/src/tabcontrollers/AudioManager.h b/src/tabcontrollers/AudioManager.h index a60bc15..db33cd5 100644 --- a/src/tabcontrollers/AudioManager.h +++ b/src/tabcontrollers/AudioManager.h @@ -11,7 +11,7 @@ class AudioTabController; class AudioManager { public: - virtual ~AudioManager(){}; + virtual ~AudioManager() {} virtual void init( AudioTabController* controller ) = 0; diff --git a/src/tabcontrollers/KeyboardInput.h b/src/tabcontrollers/KeyboardInput.h index 8821552..a4e1ba7 100644 --- a/src/tabcontrollers/KeyboardInput.h +++ b/src/tabcontrollers/KeyboardInput.h @@ -11,7 +11,7 @@ class AudioTabController; class KeyboardInput { public: - virtual ~KeyboardInput(){}; + virtual ~KeyboardInput() {} virtual void sendKeyboardInput( QString input ) = 0; virtual void sendKeyboardEnter() = 0; diff --git a/src/tabcontrollers/PttController.h b/src/tabcontrollers/PttController.h index fe78662..2106697 100644 --- a/src/tabcontrollers/PttController.h +++ b/src/tabcontrollers/PttController.h @@ -71,10 +71,10 @@ protected: protected: void checkPttStatus(); virtual QString getSettingsName() = 0; - virtual void onPttStart(){}; - virtual void onPttStop(){}; - virtual void onPttEnabled(){}; - virtual void onPttDisabled(){}; + virtual void onPttStart() {} + virtual void onPttStop() {} + virtual void onPttEnabled() {} + virtual void onPttDisabled() {} virtual vr::VROverlayHandle_t getNotificationOverlayHandle() { diff --git a/src/tabcontrollers/keyboardinput/KeyboardInputWindows.cpp b/src/tabcontrollers/keyboardinput/KeyboardInputWindows.cpp index 4dd2585..b43d91e 100644 --- a/src/tabcontrollers/keyboardinput/KeyboardInputWindows.cpp +++ b/src/tabcontrollers/keyboardinput/KeyboardInputWindows.cpp @@ -33,7 +33,7 @@ void fillKiStruct( INPUT& ip, WORD scanCode, bool keyup ) ip.ki.wScan = 0; ip.ki.dwExtraInfo = 0; ip.ki.time = 0; -}; +} /*! Calls SendInput on an INPUT struct and has associated error handling.