From 9a2c388a1caee6eaee2715af0958625384a4fba4 Mon Sep 17 00:00:00 2001
From: Vasily <vautkin@teknik.io>
Date: Thu, 27 Dec 2018 12:14:07 +0100
Subject: [PATCH] Solve initialization bug in MOveCenterTabController
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GCC gave error

../src/tabcontrollers/MoveCenterTabController.cpp:57:67: error:
operation on
‘((advsettings::MoveCenterTabController*)this)->advsettings::MoveCenterTabController::lastMoveButtonClick[0]’
may be undefined [-Werror=sequence-point]

Because assigning a value to itself twice is undefined behavior. It is
highly likely that intended behavior was to initialize both array
members to the same value at once.
---
 src/tabcontrollers/MoveCenterTabController.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tabcontrollers/MoveCenterTabController.cpp b/src/tabcontrollers/MoveCenterTabController.cpp
index 8641185..a6a6d13 100644
--- a/src/tabcontrollers/MoveCenterTabController.cpp
+++ b/src/tabcontrollers/MoveCenterTabController.cpp
@@ -54,7 +54,7 @@ void MoveCenterTabController::initStage1() {
 		m_lockZToggle = value.toBool();
 	}
 	settings->endGroup();
-    lastMoveButtonClick[0] = lastMoveButtonClick[0] = clock::now();
+    lastMoveButtonClick[0] = lastMoveButtonClick[1] = clock::now();
 }
 
 void MoveCenterTabController::initStage2(OverlayController * parent, QQuickWindow * widget) {