Rename parameters shadowing class members
Parameters with the same name as class members are ripe for introducing bugs. The fact that the "this->" syntax is optional creates confusion for maintaining programmers who can only guess at the intention.
This commit is contained in:
@@ -44,9 +44,9 @@ namespace advsettings {
|
||||
}
|
||||
|
||||
|
||||
void AudioTabController::initStage2(OverlayController * parent, QQuickWindow * widget) {
|
||||
this->parent = parent;
|
||||
this->widget = widget;
|
||||
void AudioTabController::initStage2(OverlayController * var_parent, QQuickWindow * var_widget) {
|
||||
this->parent = var_parent;
|
||||
this->widget = var_widget;
|
||||
|
||||
std::string notifKey = std::string(OverlayController::applicationKey) + ".pptnotification";
|
||||
vr::VROverlayError overlayError = vr::VROverlay()->CreateOverlay(notifKey.c_str(), notifKey.c_str(), &m_ulNotificationOverlayHandle);
|
||||
|
||||
Reference in New Issue
Block a user