Rename parameters shadowing class members

Parameters with the same name as class members are ripe for introducing
bugs. The fact that the "this->" syntax is optional creates confusion
for maintaining programmers who can only guess at the intention.
This commit is contained in:
Vasily
2018-12-27 18:27:27 +01:00
parent 412e56fa11
commit b097908b12
11 changed files with 32 additions and 32 deletions
+3 -3
View File
@@ -44,9 +44,9 @@ namespace advsettings {
}
void AudioTabController::initStage2(OverlayController * parent, QQuickWindow * widget) {
this->parent = parent;
this->widget = widget;
void AudioTabController::initStage2(OverlayController * var_parent, QQuickWindow * var_widget) {
this->parent = var_parent;
this->widget = var_widget;
std::string notifKey = std::string(OverlayController::applicationKey) + ".pptnotification";
vr::VROverlayError overlayError = vr::VROverlay()->CreateOverlay(notifKey.c_str(), notifKey.c_str(), &m_ulNotificationOverlayHandle);