From ebc2d92333ead2813f2f52a59d1eecc8f386c774 Mon Sep 17 00:00:00 2001 From: Vasily Date: Thu, 9 Jan 2020 21:26:52 +0100 Subject: [PATCH] Fix SEGFAULT when compiling with Qt 5.14.0 For unknown reasons this did not SEGFAULT with Qt<5.14.0. Official Qt docs says that deleteLater is the preferred method https://doc.qt.io/qt-5/qobject.html#deleteLater --- src/overlaycontroller.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/overlaycontroller.cpp b/src/overlaycontroller.cpp index 7a66da4..1b4ba50 100644 --- a/src/overlaycontroller.cpp +++ b/src/overlaycontroller.cpp @@ -1543,8 +1543,7 @@ void OverlayController::OnNetworkReply( QNetworkReply* reply ) "QNetworkReply::NetworkError = " << reply->error(); } - reply->request().~QNetworkRequest(); - reply->~QNetworkReply(); + reply->deleteLater(); } } // namespace advsettings