From fddae4278bf0e5e55f78599ece07d76185d8840e Mon Sep 17 00:00:00 2001 From: Vasily Date: Mon, 18 Feb 2019 00:11:29 +0100 Subject: [PATCH] Add more recommended switches Commented out switches still give errors. --- build_scripts/qt/compilers/clang-msvc.pri | 9 +++++++-- build_scripts/qt/compilers/clang.pri | 4 +++- build_scripts/qt/compilers/gcc.pri | 7 ++++++- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/build_scripts/qt/compilers/clang-msvc.pri b/build_scripts/qt/compilers/clang-msvc.pri index 0ebf1b9..2ad4460 100644 --- a/build_scripts/qt/compilers/clang-msvc.pri +++ b/build_scripts/qt/compilers/clang-msvc.pri @@ -8,7 +8,7 @@ include(common-msvc.pri) #clang-msvc does not enable the c++17 flag with qmake's c++1z flag. QMAKE_CXXFLAGS += /std:c++17 -QMAKE_CXXFLAGS += -Wextra +QMAKE_CXXFLAGS += -Wextra -Wmost QMAKE_CXXFLAGS += -Wshadow @@ -16,4 +16,9 @@ QMAKE_CXXFLAGS += -Wold-style-cast QMAKE_CXXFLAGS += -Wnon-virtual-dtor -QMAKE_CXXFLAGS += -Wpedantic +#QMAKE_CXXFLAGS += -Wpedantic + +QMAKE_CXXFLAGS += -Wcast-align -Wunused -Woverloaded-virtual -Wformat=2 +#QMAKE_CXXFLAGS += -Wconversion +#QMAKE_CXXFLAGS += -Wdouble-promotion +#QMAKE_CXXFLAGS += -Wsign-conversion diff --git a/build_scripts/qt/compilers/clang.pri b/build_scripts/qt/compilers/clang.pri index 5e18ff5..b2af85e 100644 --- a/build_scripts/qt/compilers/clang.pri +++ b/build_scripts/qt/compilers/clang.pri @@ -1,4 +1,4 @@ -QMAKE_CXXFLAGS += -Wextra +QMAKE_CXXFLAGS += -Wextra -Wmost QMAKE_CXXFLAGS += -Werror #All includes from the third-party directory will not warn. @@ -11,3 +11,5 @@ QMAKE_CXXFLAGS += -Wold-style-cast QMAKE_CXXFLAGS += -Wnon-virtual-dtor QMAKE_CXXFLAGS += -Wpedantic + +QMAKE_CXXFLAGS += -Wcast-align -Wunused -Woverloaded-virtual -Wformat=2 diff --git a/build_scripts/qt/compilers/gcc.pri b/build_scripts/qt/compilers/gcc.pri index 1fc82af..00eacf6 100644 --- a/build_scripts/qt/compilers/gcc.pri +++ b/build_scripts/qt/compilers/gcc.pri @@ -1,7 +1,7 @@ #g++-7 is needed for C++17 features. travis does not supply this by default. QMAKE_CXX = g++-7 -QMAKE_CXXFLAGS += -Wextra +QMAKE_CXXFLAGS += -Wextra -Wmost QMAKE_CXXFLAGS += -Werror @@ -12,3 +12,8 @@ QMAKE_CXXFLAGS += -Wold-style-cast QMAKE_CXXFLAGS += -Wnon-virtual-dtor QMAKE_CXXFLAGS += -Wpedantic + +QMAKE_CXXFLAGS += -Wcast-align -Wunused -Woverloaded-virtual -Wformat=2 + +# GCC only switches +QMAKE_CXXFLAGS += -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wrestrict -Wnull-dereference