From fe3bbc29599cb6245cb53042e50fba53b54fbd2e Mon Sep 17 00:00:00 2001 From: Vasily Date: Mon, 18 Feb 2019 00:47:40 +0100 Subject: [PATCH] Remove -Weffc++ from GCC The "should be initialized in the member initialization list" is incorrectly implemented on GCC. https://stackoverflow.com/questions/14002454/can-i-ignore-the-gcc-warning-foom-bar-should-be-initialized-in-the-member-i --- build_scripts/qt/compilers/clang-gcc-common-switches.pri | 2 -- build_scripts/qt/compilers/clang-msvc.pri | 2 ++ build_scripts/qt/compilers/clang.pri | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/build_scripts/qt/compilers/clang-gcc-common-switches.pri b/build_scripts/qt/compilers/clang-gcc-common-switches.pri index 52af3d9..c7a339b 100644 --- a/build_scripts/qt/compilers/clang-gcc-common-switches.pri +++ b/build_scripts/qt/compilers/clang-gcc-common-switches.pri @@ -7,5 +7,3 @@ QMAKE_CXXFLAGS += -Wold-style-cast QMAKE_CXXFLAGS += -Wnon-virtual-dtor QMAKE_CXXFLAGS += -Wcast-align -Wunused -Woverloaded-virtual -Wformat=2 - -QMAKE_CXXFLAGS += -Weffc++ diff --git a/build_scripts/qt/compilers/clang-msvc.pri b/build_scripts/qt/compilers/clang-msvc.pri index c549144..65e7957 100644 --- a/build_scripts/qt/compilers/clang-msvc.pri +++ b/build_scripts/qt/compilers/clang-msvc.pri @@ -12,6 +12,8 @@ include(clang-gcc-common-switches.pri) QMAKE_CXXFLAGS += -Wmost +QMAKE_CXXFLAGS += -Weffc++ + #QMAKE_CXXFLAGS += -Wconversion #QMAKE_CXXFLAGS += -Wdouble-promotion #QMAKE_CXXFLAGS += -Wsign-conversion diff --git a/build_scripts/qt/compilers/clang.pri b/build_scripts/qt/compilers/clang.pri index ba39d33..39ebd07 100644 --- a/build_scripts/qt/compilers/clang.pri +++ b/build_scripts/qt/compilers/clang.pri @@ -7,3 +7,5 @@ QMAKE_CXXFLAGS += -Wpedantic QMAKE_CXXFLAGS += -Werror #All includes from the third-party directory will not warn. QMAKE_CXXFLAGS += --system-header-prefix=third-party + +QMAKE_CXXFLAGS += -Weffc++