A while ago, MySensors changed to use int32_t
instead of long int (and similar for other data
types). This change was not applied to all examples,
causing some examples to fail compilation for
ESP8266 with the following message:
call of overloaded 'set(long int)' is ambiguous
This update changes the casts to match the new style.
This fixes
https://github.com/mysensors/MySensors/issues/1129
Thanks to https://github.com/henfri for reporting.
This fixes
https://github.com/mysensors/MySensors/issues/1089
and also adds Doxygen and syntax highlighting
for the following keywords:
MY_GATEWAY_MQTT_CLIENT
MY_GATEWAY_SERIAL
MY_IP_GATEWAY_ADDRESS
MY_IP_SUBNET_ADDRESS
MY_MQTT_CLIENT_ID
MY_MQTT_PUBLISH_TOPIC_PREFIX
MY_MQTT_SUBSCRIBE_TOPIC_PREFIX
* Add missing keywords and blacklist
These keywords already exist in Doxygen and should be highlighted
in the Arduino IDE.
Some keywords should not be highlighed and are therefore added
to the blacklists at end of keywords.txt
* Sort keywords in each section
* Add blacklist of MY_MQTT_TOPIC_PREFIX
A blacklist is available at the end of keywords.txt
I decided to blacklist all the LINUX keywords. I guess people
could use the Arduino IDE to edit the sketch for the raspberry
pi gateway, but I'm not sure we should encourage that.
I'll add gitler support for auto-detecting missing keywords
in a separate PR.
The comment for inclusion mode pin and the definition of
MY_INCLUSION_MODE_BUTTON_PIN did not match.
GPIO5 should be safe to use, while GPIO3 is used for the
UART which might result in conflict.
This fixes
https://github.com/mysensors/MySensors/issues/993
* Fix cppcheck issues
Fixes the following cppcheck issues:
examples/SecretKnockSensor/SecretKnockSensor.ino
305 variableScope 398 style
The scope of the variable 'timeDiff' can be reduced.
examples/SensebenderGatewaySerial/SensebenderGatewaySerial.ino
127 variableScope 398 style
The scope of the variable 'led_state' can be reduced.
* Doxygenize MyMessage / Message manipulation
This should replace the static documentation at
http://korturl.nu/stupid
I have enabled existing comments and added new comments where
necessary. Feedback on syntax and contents is welcome.
Fixes the following cppcheck issues:
examples/SecretKnockSensor/SecretKnockSensor.ino
305 variableScope 398 style
The scope of the variable 'timeDiff' can be reduced.
examples/SensebenderGatewaySerial/SensebenderGatewaySerial.ino
127 variableScope 398 style
The scope of the variable 'led_state' can be reduced.
The guide we are referring to
( https://chris.beams.io/posts/git-commit/ )
says:
shoot for 50 characters, but consider 72 the hard limit
so let Gitler consider 72 the hard limit (instead of 50).
This log message makes the Serial gateway print the serial port path,
similar to how the Ethernet gateway prints IP and port.
Example log output:
mysgw: Serial port /dev/MyCoolTTY (115200 baud) created
As mentioned by per1234 in
https://github.com/mysensors/MySensors/pull/1008
we should make it easier to find the full code contribution
guidelines.
Since we have multiple git repos, we don't want to duplicate the
guidelines in each repo. Instead, we link to the canonical source
on mysensors.org.
As discussed in
http://korturl.nu/gitler-is-a-stubborn-bastard-1
and numerous other forum threads, many people don't understand
that id generation is done by the controller.
Many new users start out their first MySensors network with a
gateway, a single sensor node and no controller. Since MySensors
defaults to AUTO node id, the node gets stuck on TSM:ID:FAIL,
like this:
TSM:ID
TSM:ID:REQ
TSF:MSG:SEND,255-255-0-0,s=255,c=3,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
TSM:ID
TSM:ID:REQ
TSF:MSG:SEND,255-255-0-0,s=255,c=3,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
TSM:ID
TSM:ID:REQ
TSF:MSG:SEND,255-255-0-0,s=255,c=3,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
TSM:ID
TSM:ID:REQ
TSF:MSG:SEND,255-255-0-0,s=255,c=3,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
!TSM:ID:FAIL
This change adds a clarifying note about the controller in the
doxygen documentation.
To use this feature, add the following to a sketch, for example
GatewayESP8266MQTTClient:
const uint8_t bssid[] = {0x00, 0xDE, 0xAD, 0xBE, 0xEF, 0x00};
#define MY_ESP8266_BSSID bssid
This feature was requested in
https://github.com/mysensors/MySensors/issues/947
* Generate Doxygen from configure
Use case: view the ./configure help text on the web.
This has been requested in
https://forum.mysensors.org/post/77751
Manually putting the help text in the forum or on mysensors.org
would lead to diverging documentation, no version management and
extra maintenance burden. This commit attempts to auto-generate
the documentation and use existing Doxygen infrastructure to
add the help text to the rest of the MySensors documentation.
In the Arduino IDE, boolean is an alias for bool.
The Arduino IDE might deprecate boolean in the future. See
https://github.com/arduino/Arduino/issues/4673 for details.
Command:
find drivers -type f | xargs sed -i 's/boolean/bool/g'
Mikael Falkvidd