Remove widget pointer from ReviveTabController

The pointer is not needed and is an anti pattern.
This commit is contained in:
Vasily
2019-07-20 21:24:03 +02:00
committed by username223
parent 66fd6e6470
commit 27b148ae12
3 changed files with 3 additions and 6 deletions
+1 -1
View File
@@ -490,7 +490,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
m_audioTabController.initStage2();
m_statisticsTabController.initStage2( this );
m_settingsTabController.initStage2( this );
m_reviveTabController.initStage2( this, m_pWindow.get() );
m_reviveTabController.initStage2( this );
m_utilitiesTabController.initStage2( this, m_pWindow.get() );
m_videoTabController.initStage2( this, m_pWindow.get() );
m_moveCenterTabController.initStage2( this, m_pWindow.get() );
+1 -3
View File
@@ -297,11 +297,9 @@ void ReviveTabController::initStage1( bool forceRevivePage )
}
}
void ReviveTabController::initStage2( OverlayController* var_parent,
QQuickWindow* var_widget )
void ReviveTabController::initStage2( OverlayController* var_parent )
{
this->parent = var_parent;
this->widget = var_widget;
}
void ReviveTabController::eventLoopTick()
+1 -2
View File
@@ -70,7 +70,6 @@ class ReviveTabController : public QObject
private:
OverlayController* parent;
QQuickWindow* widget;
bool m_isOverlayInstalled = false;
int m_gripButtonMode = 0;
@@ -98,7 +97,7 @@ private:
public:
void initStage1( bool forceRevivePage );
void initStage2( OverlayController* parent, QQuickWindow* widget );
void initStage2( OverlayController* parent );
void eventLoopTick();