Remove widget pointer from FixFloorTabController

The pointer is not needed and is an anti pattern.
This commit is contained in:
Vasily
2019-07-20 21:24:03 +02:00
committed by username223
parent 6a3e22bdd6
commit 5f35a11381
3 changed files with 3 additions and 6 deletions
+1 -1
View File
@@ -486,7 +486,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
m_steamVRTabController.initStage2( this );
m_chaperoneTabController.initStage2( this );
m_fixFloorTabController.initStage2( this, m_pWindow.get() );
m_fixFloorTabController.initStage2( this );
m_audioTabController.initStage2( this, m_pWindow.get() );
m_statisticsTabController.initStage2( this, m_pWindow.get() );
m_settingsTabController.initStage2( this, m_pWindow.get() );
+1 -3
View File
@@ -7,11 +7,9 @@ namespace advsettings
{
void FixFloorTabController::initStage1() {}
void FixFloorTabController::initStage2( OverlayController* var_parent,
QQuickWindow* var_widget )
void FixFloorTabController::initStage2( OverlayController* var_parent )
{
this->parent = var_parent;
this->widget = var_widget;
}
void FixFloorTabController::eventLoopTick(
+1 -2
View File
@@ -19,7 +19,6 @@ class FixFloorTabController : public QObject
private:
OverlayController* parent;
QQuickWindow* widget;
float controllerUpOffsetCorrection
= 0.062f; // Controller touchpad facing upwards
@@ -55,7 +54,7 @@ private:
public:
void initStage1();
void initStage2( OverlayController* parent, QQuickWindow* widget );
void initStage2( OverlayController* parent );
void eventLoopTick( vr::TrackedDevicePose_t* devicePoses );