Remove widget pointer from SettingsTabController

The pointer is not needed and is an anti pattern.
This commit is contained in:
Vasily
2019-07-20 21:24:03 +02:00
committed by username223
parent 7728744cdd
commit 66fd6e6470
3 changed files with 3 additions and 6 deletions
+1 -1
View File
@@ -489,7 +489,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
m_fixFloorTabController.initStage2( this );
m_audioTabController.initStage2();
m_statisticsTabController.initStage2( this );
m_settingsTabController.initStage2( this, m_pWindow.get() );
m_settingsTabController.initStage2( this );
m_reviveTabController.initStage2( this, m_pWindow.get() );
m_utilitiesTabController.initStage2( this, m_pWindow.get() );
m_videoTabController.initStage2( this, m_pWindow.get() );
+1 -3
View File
@@ -19,11 +19,9 @@ void SettingsTabController::initStage1()
}
}
void SettingsTabController::initStage2( OverlayController* var_parent,
QQuickWindow* var_widget )
void SettingsTabController::initStage2( OverlayController* var_parent )
{
this->parent = var_parent;
this->widget = var_widget;
}
void SettingsTabController::eventLoopTick()
+1 -2
View File
@@ -20,7 +20,6 @@ class SettingsTabController : public QObject
private:
OverlayController* parent;
QQuickWindow* widget;
unsigned settingsUpdateCounter = 0;
@@ -29,7 +28,7 @@ private:
public:
void initStage1();
void initStage2( OverlayController* parent, QQuickWindow* widget );
void initStage2( OverlayController* parent );
void eventLoopTick();