Remove widget pointer from StatisticsTabController
The pointer is not needed and is an anti pattern.
This commit is contained in:
@@ -488,7 +488,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
|
||||
m_chaperoneTabController.initStage2( this );
|
||||
m_fixFloorTabController.initStage2( this );
|
||||
m_audioTabController.initStage2();
|
||||
m_statisticsTabController.initStage2( this, m_pWindow.get() );
|
||||
m_statisticsTabController.initStage2( this );
|
||||
m_settingsTabController.initStage2( this, m_pWindow.get() );
|
||||
m_reviveTabController.initStage2( this, m_pWindow.get() );
|
||||
m_utilitiesTabController.initStage2( this, m_pWindow.get() );
|
||||
|
||||
@@ -7,11 +7,9 @@ namespace advsettings
|
||||
{
|
||||
void StatisticsTabController::initStage1() {}
|
||||
|
||||
void StatisticsTabController::initStage2( OverlayController* var_parent,
|
||||
QQuickWindow* var_widget )
|
||||
void StatisticsTabController::initStage2( OverlayController* var_parent )
|
||||
{
|
||||
this->parent = var_parent;
|
||||
this->widget = var_widget;
|
||||
}
|
||||
|
||||
void StatisticsTabController::eventLoopTick(
|
||||
|
||||
@@ -26,7 +26,6 @@ class StatisticsTabController : public QObject
|
||||
|
||||
private:
|
||||
OverlayController* parent;
|
||||
QQuickWindow* widget;
|
||||
|
||||
bool rotationResetFlag = false;
|
||||
float rotationOffset = 0.0f;
|
||||
@@ -53,7 +52,7 @@ private:
|
||||
|
||||
public:
|
||||
void initStage1();
|
||||
void initStage2( OverlayController* parent, QQuickWindow* widget );
|
||||
void initStage2( OverlayController* parent );
|
||||
|
||||
void eventLoopTick( vr::TrackedDevicePose_t* devicePoses,
|
||||
float leftSpeed,
|
||||
|
||||
Reference in New Issue
Block a user