Remove widget pointer from SettingsTabController
The pointer is not needed and is an anti pattern.
This commit is contained in:
@@ -489,7 +489,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
|
|||||||
m_fixFloorTabController.initStage2( this );
|
m_fixFloorTabController.initStage2( this );
|
||||||
m_audioTabController.initStage2();
|
m_audioTabController.initStage2();
|
||||||
m_statisticsTabController.initStage2( this );
|
m_statisticsTabController.initStage2( this );
|
||||||
m_settingsTabController.initStage2( this, m_pWindow.get() );
|
m_settingsTabController.initStage2( this );
|
||||||
m_reviveTabController.initStage2( this, m_pWindow.get() );
|
m_reviveTabController.initStage2( this, m_pWindow.get() );
|
||||||
m_utilitiesTabController.initStage2( this, m_pWindow.get() );
|
m_utilitiesTabController.initStage2( this, m_pWindow.get() );
|
||||||
m_videoTabController.initStage2( this, m_pWindow.get() );
|
m_videoTabController.initStage2( this, m_pWindow.get() );
|
||||||
|
|||||||
@@ -19,11 +19,9 @@ void SettingsTabController::initStage1()
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void SettingsTabController::initStage2( OverlayController* var_parent,
|
void SettingsTabController::initStage2( OverlayController* var_parent )
|
||||||
QQuickWindow* var_widget )
|
|
||||||
{
|
{
|
||||||
this->parent = var_parent;
|
this->parent = var_parent;
|
||||||
this->widget = var_widget;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void SettingsTabController::eventLoopTick()
|
void SettingsTabController::eventLoopTick()
|
||||||
|
|||||||
@@ -20,7 +20,6 @@ class SettingsTabController : public QObject
|
|||||||
|
|
||||||
private:
|
private:
|
||||||
OverlayController* parent;
|
OverlayController* parent;
|
||||||
QQuickWindow* widget;
|
|
||||||
|
|
||||||
unsigned settingsUpdateCounter = 0;
|
unsigned settingsUpdateCounter = 0;
|
||||||
|
|
||||||
@@ -29,7 +28,7 @@ private:
|
|||||||
|
|
||||||
public:
|
public:
|
||||||
void initStage1();
|
void initStage1();
|
||||||
void initStage2( OverlayController* parent, QQuickWindow* widget );
|
void initStage2( OverlayController* parent );
|
||||||
|
|
||||||
void eventLoopTick();
|
void eventLoopTick();
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user