SteamFrame/OpenVR-AdvancedSettings-frame
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove widget pointer from StatisticsTabController

Browse Source 
The pointer is not needed and is an anti pattern.
This commit is contained in:
Vasily
2019-07-20 21:24:03 +02:00
committed by username223
parent 7a6c8b662d
commit 7728744cdd
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/overlaycontroller.cpp
+1 -1
View File
@@ -488,7 +488,7 @@ void OverlayController::SetWidget( QQuickItem* quickItem,
m_chaperoneTabController.initStage2( this ); m_chaperoneTabController.initStage2( this );
m_fixFloorTabController.initStage2( this ); m_fixFloorTabController.initStage2( this );
m_audioTabController.initStage2(); m_audioTabController.initStage2();
m_statisticsTabController.initStage2( this, m_pWindow.get() ); m_statisticsTabController.initStage2( this );
m_settingsTabController.initStage2( this, m_pWindow.get() ); m_settingsTabController.initStage2( this, m_pWindow.get() );
m_reviveTabController.initStage2( this, m_pWindow.get() ); m_reviveTabController.initStage2( this, m_pWindow.get() );
m_utilitiesTabController.initStage2( this, m_pWindow.get() ); m_utilitiesTabController.initStage2( this, m_pWindow.get() );
src/tabcontrollers/StatisticsTabController.cpp
+1 -3
View File
@@ -7,11 +7,9 @@ namespace advsettings
{ {
void StatisticsTabController::initStage1() {} void StatisticsTabController::initStage1() {}
void StatisticsTabController::initStage2( OverlayController* var_parent, void StatisticsTabController::initStage2( OverlayController* var_parent )
QQuickWindow* var_widget )
{ {
this->parent = var_parent; this->parent = var_parent;
this->widget = var_widget;
} }
void StatisticsTabController::eventLoopTick( void StatisticsTabController::eventLoopTick(
src/tabcontrollers/StatisticsTabController.h
+1 -2
View File
@@ -26,7 +26,6 @@ class StatisticsTabController : public QObject
private: private:
OverlayController* parent; OverlayController* parent;
QQuickWindow* widget;
bool rotationResetFlag = false; bool rotationResetFlag = false;
float rotationOffset = 0.0f; float rotationOffset = 0.0f;
@@ -53,7 +52,7 @@ private:
public: public:
void initStage1(); void initStage1();
void initStage2( OverlayController* parent, QQuickWindow* widget ); void initStage2( OverlayController* parent );
void eventLoopTick( vr::TrackedDevicePose_t* devicePoses, void eventLoopTick( vr::TrackedDevicePose_t* devicePoses,
float leftSpeed, float leftSpeed,