Add -Wextra-semi and fix occurences

build_scripts/qt/compilers/clang.pri

@@ -10,3 +10,5 @@ QMAKE_CXXFLAGS += --system-header-prefix=third-party
 
 # Sign conversion warns on auto generated Qt MOC files.
 QMAKE_CXXFLAGS += -Weffc++ -Wconversion -Wno-sign-conversion
+
+QMAKE_CXXFLAGS += -Wextra-semi

build_scripts/qt/compilers/gcc.pri

@@ -12,3 +12,5 @@ QMAKE_CXXFLAGS += -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wrestric
 
 # Sign conversion warns on auto generated Qt MOC files.
 QMAKE_CXXFLAGS += -Wconversion -Wno-sign-conversion
+
+QMAKE_CXXFLAGS += -Wextra-semi

src/overlaycontroller.h

@@ -165,7 +165,7 @@ public:
     bool isDesktopMode()
     {
         return m_desktopMode;
-    };
+    }
 
     utils::ChaperoneUtils& chaperoneUtils() noexcept
     {

src/tabcontrollers/AudioManager.h

@@ -11,7 +11,7 @@ class AudioTabController;
 class AudioManager
 {
 public:
-    virtual ~AudioManager(){};
+    virtual ~AudioManager() {}
 
     virtual void init( AudioTabController* controller ) = 0;
 

src/tabcontrollers/KeyboardInput.h

@@ -11,7 +11,7 @@ class AudioTabController;
 class KeyboardInput
 {
 public:
-    virtual ~KeyboardInput(){};
+    virtual ~KeyboardInput() {}
 
     virtual void sendKeyboardInput( QString input ) = 0;
     virtual void sendKeyboardEnter() = 0;

src/tabcontrollers/PttController.h

@@ -71,10 +71,10 @@ protected:
 protected:
     void checkPttStatus();
     virtual QString getSettingsName() = 0;
-    virtual void onPttStart(){};
+    virtual void onPttStart() {}
-    virtual void onPttStop(){};
+    virtual void onPttStop() {}
-    virtual void onPttEnabled(){};
+    virtual void onPttEnabled() {}
-    virtual void onPttDisabled(){};
+    virtual void onPttDisabled() {}
 
     virtual vr::VROverlayHandle_t getNotificationOverlayHandle()
     {

src/tabcontrollers/keyboardinput/KeyboardInputWindows.cpp

@@ -33,7 +33,7 @@ void fillKiStruct( INPUT& ip, WORD scanCode, bool keyup )
     ip.ki.wScan = 0;
     ip.ki.dwExtraInfo = 0;
     ip.ki.time = 0;
-};
+}
 
 /*!
 Calls SendInput on an INPUT struct and has associated error handling.